Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from Devin: try to implement the element keyword #1739

Closed
wants to merge 1 commit into from
Closed

from Devin: try to implement the element keyword #1739

wants to merge 1 commit into from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Mar 17, 2025 •
edited
Loading

Assessing if Devin can implement things with enough guidance

the prompt 
Given this design document: https://github.com/emberjs/rfcs/blob/master/text/0389-dynamic-tag-names.md
And knowing that implementation needs to happen in this repo: https://github.com/glimmerjs/glimmer-vm/
And the tests, documentation, and usage from the polyfill: https://github.com/tildeio/ember-element-helper

In glimmer-vm, add a new keyword, `{{#element}}`  that allows users to dynamically define an element, following the design document.

glimmer-vm uses pnpm.

In order to finish this work:

- tests from ember-element-helper must be ported to glimmer-vm
- lints must pass
- the build must succeed
- tests must pass

Doing this work will allow us to drop a dependency from our internal projects, and will improve install / clean times, as well as overall framework cohesion when onboarding new developers.

Devin Session (if you have access)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025 •
edited
Loading

This PRmain
Dev 
584K └─┬ .
171K   ├── runtime
160K   ├── syntax
100K   ├── compiler
 58K   ├── opcode-compiler
 27K   ├── manager
 19K   ├── validator
 11K   ├── program
8.9K   ├── reference
7.2K   ├── destroyable
6.3K   ├── util
4.3K   ├── node
3.4K   ├── global-context
2.5K   ├── wire-format
1.0K   ├── vm
969B   ├── encoder
844B   ├── vm-babel-plugins
606B   └── owner

583K └─┬ .
169K   ├── runtime
160K   ├── syntax
100K   ├── compiler
 58K   ├── opcode-compiler
 27K   ├── manager
 19K   ├── validator
 11K   ├── program
8.9K   ├── reference
7.2K   ├── destroyable
6.3K   ├── util
4.3K   ├── node
3.4K   ├── global-context
2.5K   ├── wire-format
1.0K   ├── vm
969B   ├── encoder
844B   ├── vm-babel-plugins
606B   └── owner
Prod 
231K └─┬ .
 70K   ├── syntax
 64K   ├── runtime
 48K   ├── compiler
 18K   ├── opcode-compiler
7.9K   ├── manager
4.8K   ├── program
4.0K   ├── validator
3.6K   ├── reference
2.4K   ├── util
2.1K   ├── node
1.6K   ├── wire-format
1.5K   ├── destroyable
737B   ├── vm
594B   ├── global-context
516B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner

230K └─┬ .
 70K   ├── syntax
 63K   ├── runtime
 48K   ├── compiler
 18K   ├── opcode-compiler
7.9K   ├── manager
4.8K   ├── program
4.0K   ├── validator
3.6K   ├── reference
2.4K   ├── util
2.1K   ├── node
1.6K   ├── wire-format
1.5K   ├── destroyable
737B   ├── vm
594B   ├── global-context
516B   ├── encoder
469B   ├── vm-babel-plugins
155B   └── owner

@NullVoxPopuli NullVoxPopuli force-pushed the devin/attempt-to-implement-element-keyword branch 4 times, most recently from 1c0e39c to ce7409d Compare March 17, 2025 21:29
@NullVoxPopuli NullVoxPopuli force-pushed the devin/attempt-to-implement-element-keyword branch from ce7409d to 6a15f71 Compare March 17, 2025 21:49
@NullVoxPopuli NullVoxPopuli deleted the devin/attempt-to-implement-element-keyword branch March 18, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NullVoxPopuli